Fixes for comparing and avoiding singletons #1458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to address problem shown by z1720.scala. Another fix to avoidance is needed to make it pass completely.
Bring in line with comparisons. Fixes z1720 for good.
| @@ -1,4 +0,0 @@ | |||
| trait F[@specialized(Int) T1, R] { | |||
There was a problem hiding this comment.
Why were the files in this directory deleted?
There was a problem hiding this comment.
It was an oversight. I'll add spec-t5545l to tests.
Needs to be done in pos-special because junit tests do not recognize _1, _2.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two interesting problems involving singleton types exhibited by one test case. Review by @smarter.